FIX Bug page_y url #32119
Merged
FIX Bug page_y url #32119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, 'reposition' modified the url by assigning variables other than page_y, for example : https://XXX/ticket/card.php?id=2158&action=dellink&token=e88288a7e4488ebafb81a80fa5f58913&dellinkid=20308.60009765625.60009765625&page_y=2113.60009765625
eldy
reviewed
Nov 27, 2024
| @@ -242,38 +242,28 @@ | |||
| // Code to manage reposition | |||
| print "\n/* JS CODE TO ENABLE reposition management (does not work if a redirect is done after action of submission) */\n"; | |||
| print ' | |||
| jQuery(document).ready(function() { | |||
| /* If page_y set, we set scrollbar with it */ | |||
There was a problem hiding this comment.
Why removing all the comments that help to understand the code ?
eldy
reviewed
Nov 27, 2024
| if (page_y == 0) page_y = jQuery("#page_y").text(); /* search in POST parameter that is filed at bottom of page */ | ||
| if (page_y > 0) | ||
| { | ||
| console.log("page_y found is "+page_y); |
There was a problem hiding this comment.
Same question for console.logthat are necessary to debug.
A bug fix must always have the minimal footprint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX
In some cases, 'reposition' modified the url by assigning variables other than page_y, for example : https://XXX/ticket/card.php?id=2158&action=dellink&token=e88288a7e4488ebafb81a80fa5f58913&dellinkid=20308.60009765625.60009765625&page_y=2113.60009765625
Here, for example, we were unable to delete a linked element, which is logical when you see the contents of dellinkid